[bug #45122] [base][patch] Pattern phase support

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #45122] [base][patch] Pattern phase support

Fred Kiefer-3
URL:
  <http://savannah.gnu.org/bugs/?45122>

                 Summary: [base][patch] Pattern phase support
                 Project: GNUstep
            Submitted by: tedge
            Submitted on: Sun 17 May 2015 09:41:52 PM GMT
                Category: Backend
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

  Setup: VirtualBox 4.3 + Ubuntu 14.04 guest, Clang, current SVN trunk

  Patch adds support for the NSGraphicsContext's patternPhase offset when
drawing a pattern. (Patterns are currently always drawn with zero offset,
regardless of the draw context's patternPhase value).

  Pattern phase is useful for scrolling or animating a pattern-filled area, as
well as for tiling a pattern that's pinned to a nonzero origin.

  Patch also corrects a minor issue with getting the pattern size: The size
message is sent to a safer target object - the received parameter,
pattern_image - instead of the instance member, pattern. (Seems like they're
always the same object, but it's safer not to assume this).

  Test program is also attached.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 17 May 2015 09:41:52 PM GMT  Name: TestPatternPhase.m  Size: 2kB  
By: tedge

<http://savannah.gnu.org/bugs/download.php?file_id=34039>
-------------------------------------------------------
Date: Sun 17 May 2015 09:41:52 PM GMT  Name: back_PatternPhase.patch  Size:
2kB   By: tedge

<http://savannah.gnu.org/bugs/download.php?file_id=34038>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45122>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep
Reply | Threaded
Open this post in threaded view
|

[bug #45122] [base][patch] Pattern phase support

Fred Kiefer-3
Follow-up Comment #1, bug #45122 (project gnustep):

Sorry, typo in the title - this is a backend issue, not base; Title should
read:
[back][patch] Pattern phase support



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45122>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep
Reply | Threaded
Open this post in threaded view
|

[bug #45122] [back][patch] Pattern phase support

Fred Kiefer-3
Update of bug #45122 (project gnustep):

              Item Group:                     Bug => Change Request        
                  Status:                    None => Ready For Test        
             Assigned to:                    None => FredKiefer            
             Open/Closed:                    Open => In Test                
                 Summary: [base][patch] Pattern phase support => [back][patch]
Pattern phase support

    _______________________________________________________

Follow-up Comment #2:

Thank you for providing this excellent patch. I just commited it to SVN.
If you have future patchs to GNUstep, there is a specific category for that in
Savannah. Feel free to submit them there.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45122>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep
Reply | Threaded
Open this post in threaded view
|

[bug #45122] [back][patch] Pattern phase support

Fred Kiefer-3
Update of bug #45122 (project gnustep):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                 In Test => Closed                


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45122>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep