[bug #51113] No menu bar in Gtk theme broken

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #51113] No menu bar in Gtk theme broken

dsdsdsds
URL:
  <http://savannah.gnu.org/bugs/?51113>

                 Summary: No menu bar in Gtk theme broken
                 Project: GNUstep
            Submitted by: thebeing
            Submitted on: Thu 25 May 2017 09:11:48 AM UTC
                Category: Libraries
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

I've just been playing around with the Gtk.theme (on an Ubuntu 17.04
installation with gtk 2.24.31) and it seems that it fails to render the
in-window menu bar. There is the following warning printed from Gtk:

(Ink:28940): Gtk-WARNING **: Attempting to add a widget with type GtkMenuBar
to a container of type GtkFixed, but the widget is already inside a container
of type GtkFixed, the GTK+ FAQ at
http://library.gnome.org/devel/gtk-faq/stable/ explains how to reparent a
widget.

I think this would be for someone with some actual knowledge of gtk to look
at.

Thanks!

Niels




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51113>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep
Reply | Threaded
Open this post in threaded view
|

[bug #51113] No in-window menu bar with the Gtk theme

dsdsdsds
Update of bug #51113 (project gnustep):

                 Summary: No menu bar in Gtk theme broken => No in-window menu
bar with the Gtk theme


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51113>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep
Reply | Threaded
Open this post in threaded view
|

[bug #51113] No in-window menu bar with the Gtk theme

dsdsdsds
Follow-up Comment #1, bug #51113 (project gnustep):

That GTK link is of no use at all. After a few automatic redirects you end up
on a page that is completely unrelated to the topic. Googling for GTK an
reparent brings up this page:
http://www.geany.org/manual/gtk/gtk-faq/x636.html

And searching the GTK theme code for gtk_container_add brings up two usages in
setup_gtk_widget() in the file GGnomeThemeInitialization.m. As protoLayout
gets created with this call
protoLayout = gtk_fixed_new();
it could be the GtkFixed in the error message. That could mean that GtkMenuBar
is the widget passed into this function.
The only GtkMenuBar that gets created is on line 152 of that file
    GtkWidget *gtkMenuBar = gtk_menu_bar_new();

and if you look closely this gets added twice, once on line 153 an also on
line 175. Most likely one of this calls is superfluous , perhaps the first
one?

This analysis was done without any "actual knowledge of gtk" so please verify
it yourself.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51113>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep
Reply | Threaded
Open this post in threaded view
|

[bug #51113] No in-window menu bar with the Gtk theme

dsdsdsds
Update of bug #51113 (project gnustep):

                  Status:                    None => Ready For Test        
             Assigned to:                    None => FredKiefer            
             Open/Closed:                    Open => In Test                

    _______________________________________________________

Follow-up Comment #2:

I just submitted the change I suggested below. Please test it and report back.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51113>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep
Reply | Threaded
Open this post in threaded view
|

[bug #51113] No in-window menu bar with the Gtk theme

dsdsdsds
Update of bug #51113 (project gnustep):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                 In Test => Closed                


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51113>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep