[bug #52730] [GWorkspace] Misc compiler warnings

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug #52730] [GWorkspace] Misc compiler warnings

dsdsdsds
URL:
  <http://savannah.gnu.org/bugs/?52730>

                 Summary: [GWorkspace] Misc compiler warnings
                 Project: GNUstep
            Submitted by: yavor
            Submitted on: Fri 22 Dec 2017 10:50:53 PM EET
                Category: Application
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

The attached patch fixes these compiler warnings:
 - @interface of class ‘NSPopUpMenu’ not found
 - ‘NSCollectionViewItem’ may not respond to ‘-setTag:’
 - logical not is only applied to the left hand side of comparison
 - initialization from distinct Objective-C type
 - variable ‘is_daemon’ set but not used
 - comparison between pointer and zero character constant

About is_daemon in mdextractor.m, perhaps it wasn't intended to be a local
variable?



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 22 Dec 2017 10:50:53 PM EET  Name:
0001-Fix-miscellaneous-compiler-warnings.patch  Size: 5KiB   By: yavor

<http://savannah.gnu.org/bugs/download.php?file_id=42707>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52730>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep
Reply | Threaded
Open this post in threaded view
|

[bug #52730] [GWorkspace] Misc compiler warnings

dsdsdsds
Update of bug #52730 (project gnustep):

                  Status:                    None => Ready For Test        
             Assigned to:                    None => rmottola              
             Open/Closed:                    Open => In Test                

    _______________________________________________________

Follow-up Comment #1:

Yavor - i accepted most of your fixes and actually extended some cleanups once
I saw a pattern.
I think that the NSPopUpMenu however is bogus or a false positive, I don't get
that warning and the "setTag" is strange, NSPopUpMenu should return an
NSMenuItem which responds to tag/setTag

Other fixes happened in the past weeks too, so please try.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52730>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep
Reply | Threaded
Open this post in threaded view
|

[bug #52730] [GWorkspace] Misc compiler warnings

dsdsdsds
Follow-up Comment #2, bug #52730 (project gnustep):

The warnings occur with GUI 0.25.0, just rechecked with 0.26.2 and they are
the same.  Perhaps you test with Clang and that's why you don't get them?

There is no class NSPopUpMenu so I don't think it's bogus or a false positive.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52730>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep
Reply | Threaded
Open this post in threaded view
|

[bug #52730] [GWorkspace] Misc compiler warnings

dsdsdsds
Update of bug #52730 (project gnustep):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                 In Test => Closed                


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52730>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-gnustep mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/bug-gnustep