libs-quartzcore won't build

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

libs-quartzcore won't build

Stjepan Brkić
Hello all,

Couple of days ago I started getting errors while running make in libs-quartzcore.

I was open to the possibility that I broke something, so today I wiped all GNUstep related files and folders and cloned and rebuilt everything from scratch. The error message persists.

The eror message:

CALayer.m:102:13: error: synthesized property 'contentsScale' must either be named the same as a compatible instance variable or must explicitly name an instance variable
@synthesize contentsScale=_contentsScale;

It looks to me that commit 794a903ab800ec3df27787903497b59f7a75bcb6:
Author: Ivan Vučica <[hidden email]>
Date:   Thu Jun 7 22:26:36 2018 +0000

    Fixes for borderColor and contentsScale from pull request #2.
   
    Clarify definition of borderColor. Fix implementation of
    borderColor. Introduce synthesis of contentsScale.


breaks this, but I'm not entirely sure.

Can anyone confirm this?

Thanks,
Stjepan

_______________________________________________
Gnustep-dev mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/gnustep-dev
Reply | Threaded
Open this post in threaded view
|

Re: libs-quartzcore won't build

Fred Kiefer
I think you are correct here. Could you please fix this yourself? I am still travelling and won’t be able to do it until next week.

Fred

Unterwegs

Am 09.06.2018 um 07:17 schrieb Stjepan Brkić <[hidden email]>:

Hello all,

Couple of days ago I started getting errors while running make in libs-quartzcore.

I was open to the possibility that I broke something, so today I wiped all GNUstep related files and folders and cloned and rebuilt everything from scratch. The error message persists.

The eror message:

CALayer.m:102:13: error: synthesized property 'contentsScale' must either be named the same as a compatible instance variable or must explicitly name an instance variable
@synthesize contentsScale=_contentsScale;

It looks to me that commit 794a903ab800ec3df27787903497b59f7a75bcb6:
Author: Ivan Vučica <[hidden email]>
Date:   Thu Jun 7 22:26:36 2018 +0000

    Fixes for borderColor and contentsScale from pull request #2.
   
    Clarify definition of borderColor. Fix implementation of
    borderColor. Introduce synthesis of contentsScale.


breaks this, but I'm not entirely sure.

Can anyone confirm this?

Thanks,
Stjepan
_______________________________________________
Gnustep-dev mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/gnustep-dev

_______________________________________________
Gnustep-dev mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/gnustep-dev
Reply | Threaded
Open this post in threaded view
|

Fwd: libs-quartzcore won't build

Stjepan Brkić
Fixed by adding by adding CGFloat _contentsScale ivar to Headers/QuartzCore/CALayer.h (#PR3).

sub, 9. lip 2018. u 13:00 Fred Kiefer <[hidden email]> napisao je:
I think you are correct here. Could you please fix this yourself? I am still travelling and won’t be able to do it until next week.

Fred

Unterwegs

Am 09.06.2018 um 07:17 schrieb Stjepan Brkić <[hidden email]>:

Hello all,

Couple of days ago I started getting errors while running make in libs-quartzcore.

I was open to the possibility that I broke something, so today I wiped all GNUstep related files and folders and cloned and rebuilt everything from scratch. The error message persists.

The eror message:

CALayer.m:102:13: error: synthesized property 'contentsScale' must either be named the same as a compatible instance variable or must explicitly name an instance variable
@synthesize contentsScale=_contentsScale;

It looks to me that commit 794a903ab800ec3df27787903497b59f7a75bcb6:
Author: Ivan Vučica <[hidden email]>
Date:   Thu Jun 7 22:26:36 2018 +0000

    Fixes for borderColor and contentsScale from pull request #2.
   
    Clarify definition of borderColor. Fix implementation of
    borderColor. Introduce synthesis of contentsScale.


breaks this, but I'm not entirely sure.

Can anyone confirm this?

Thanks,
Stjepan
_______________________________________________
Gnustep-dev mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/gnustep-dev

_______________________________________________
Gnustep-dev mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/gnustep-dev
Reply | Threaded
Open this post in threaded view
|

Re: libs-quartzcore won't build

Ivan Vučica-2
Sorry about this. I did the merge on a machine without a working GS,
so I omitted trying to build. It's amazing I only missed this one
thing, really.

Stjepan, I'm happy that the IM hints helped :-)

Please remove the extra newline from ChangeLog and I will
merge this at the earliest convenience. Thanks!
On Sat, Jun 9, 2018 at 2:49 PM Stjepan Brkić <[hidden email]> wrote:

>
> Fixed by adding by adding CGFloat _contentsScale ivar to Headers/QuartzCore/CALayer.h (#PR3).
>
> sub, 9. lip 2018. u 13:00 Fred Kiefer <[hidden email]> napisao je:
>>
>> I think you are correct here. Could you please fix this yourself? I am still travelling and won’t be able to do it until next week.
>>
>> Fred
>>
>> Unterwegs
>>
>> Am 09.06.2018 um 07:17 schrieb Stjepan Brkić <[hidden email]>:
>>
>> Hello all,
>>
>> Couple of days ago I started getting errors while running make in libs-quartzcore.
>>
>> I was open to the possibility that I broke something, so today I wiped all GNUstep related files and folders and cloned and rebuilt everything from scratch. The error message persists.
>>
>> The eror message:
>>
>> CALayer.m:102:13: error: synthesized property 'contentsScale' must either be named the same as a compatible instance variable or must explicitly name an instance variable
>> @synthesize contentsScale=_contentsScale;
>>
>> It looks to me that commit 794a903ab800ec3df27787903497b59f7a75bcb6:
>> Author: Ivan Vučica <[hidden email]>
>> Date:   Thu Jun 7 22:26:36 2018 +0000
>>
>>     Fixes for borderColor and contentsScale from pull request #2.
>>
>>     Clarify definition of borderColor. Fix implementation of
>>     borderColor. Introduce synthesis of contentsScale.
>>
>> breaks this, but I'm not entirely sure.
>>
>> Can anyone confirm this?
>>
>> Thanks,
>> Stjepan
>>
>> _______________________________________________
>> Gnustep-dev mailing list
>> [hidden email]
>> https://lists.gnu.org/mailman/listinfo/gnustep-dev
>
> _______________________________________________
> Gnustep-dev mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/gnustep-dev

_______________________________________________
Gnustep-dev mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/gnustep-dev